Update jQuery to 3.5.0 #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey, thank you for proposing this fix. The new jquery version seems to be the regular version despite its name indicating it is the minified version. We should use that version instead. |
perrito666
requested changes
Feb 23, 2023
Contributor
perrito666
left a comment
There was a problem hiding this comment.
Please replace site/themes/learn/static/js/jquery-3.5.0.min.js with the actual minified version of it.
Contributor
Author
|
@perrito666 the file has been updated. |
perrito666
approved these changes
Feb 24, 2023
Contributor
Author
|
@perrito666 @natefinch would you please review and merge the PR? Thanks. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated jQuery to 3.5.0 to address the following issue.
#431
Whitesource vulnerability scan was run on the project. It showed mage having CVE-2020-11023 issue. This PR will fix the issue.