Ensure MAGEFILE_VERBOSE set in compiled magefile #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `mage -compile=foo`, ensure that passing `-v` to the produced binary sets MAGEFILE_VERBOSE. This is necessary for `mg.Verbose()` to return the correct value.
natefinch
requested changes
Apr 16, 2020
Member
natefinch
left a comment
There was a problem hiding this comment.
Thank you for finding this... clearly no one has been using mg.Verbose :) If you could add a separate test for mg.Verbose getting set, that would be perfect.
... and revert the change to TestVerbose.
Contributor
Author
|
I've reverted the change to TestVerbose, and introduced a new target and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
mage -compile=foo, ensure that passing-vto the produced binary sets MAGEFILE_VERBOSE.This is necessary for
mg.Verbose()to return thecorrect value.
Fixes #248