Skip to content

Conversation

@guumaster
Copy link
Contributor

It was confusing for me to get started with the current example, I don't have dep installed and I think the example with go mod download may be a better example.

Also change the order of installation methods, recommending go modules instead of $GOPATH.

Also change the order of installation methods, recommending `go modules` instead of $GOPATH.
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@guumaster
Copy link
Contributor Author

@natefinch do you need something else on this branch before merging it?

@natefinch
Copy link
Member

Sorry, thought I already merged this. Will do so now.

@natefinch natefinch merged commit 310e198 into magefile:master Apr 16, 2020
@guumaster guumaster deleted the patch-1 branch April 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants