Set magefiles working directory #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefinch
requested changes
Jan 13, 2020
Member
natefinch
left a comment
There was a problem hiding this comment.
Thank you for the PR. This looks really good and I agree it's needed.
However, I think -w makes more sense than -C. Not sure why it would be C, I presume that's what some other tool uses, but I prefer that flags make sense on their own in this tool.
Also, I think uppercase flags are an anti-pattern regardless.
Finally, can you alphabetize the flags in the docs?
Contributor
Author
|
Yes, tar and Git 😅 great, I will work on that :) |
natefinch
approved these changes
Jan 17, 2020
Member
natefinch
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
-wflag for changing the magefiles working directory. Currently reading magefiles from other directory with-dflag set it as working directory for the magefiles.This doesn't break any existing code since the
-wflag default value is the same as-d, just people using explicitly a-wflag will get this behavior.Fixes: #243