Set GOARCH to amd64 for TestListMagefilesIgnoresRespectsGOOSArg #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestListMagefilesIgnoresRespectsGOOSArg test tries to list go files with a different GOOS arg by setting GOOS to windows on Linux systems and vice versa. This test works fine on amd64, but breaks on arm64 because a windows/arm64 pair is not available yet and as a result, the `go list` command underlying the `Magefiles` function fails. Fix this problem by keeping GOARCH as amd64 so that the go list command does not fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestListMagefilesIgnoresRespectsGOOSArg test tries to list go
files with a different GOOS arg by setting GOOS to windows on Linux
systems and vice versa. This test works fine on amd64, but breaks on
arm64 because a windows/arm64 pair is not available yet and as a
result, the
go listcommand underlying theMagefilesfunctionfails.
Fix this problem by keeping GOARCH as amd64 so that the go list
command does not fail.