GUI: Write PSBTs to file with binary mode

achow101 · achow101 · commit cc3971c9ff53 · 2021-01-18T20:55:08.000-05:00
diff --git a/src/qt/psbtoperationsdialog.cpp b/src/qt/psbtoperationsdialog.cpp
@@ -145,7 +145,7 @@ void PSBTOperationsDialog::saveTransaction() {
     if (filename.isEmpty()) {
         return;
     }
-    std::ofstream out(filename.toLocal8Bit().data());
+    std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out | std::ofstream::binary);
     out << ssTx.str();
     out.close();
     showStatus(tr("PSBT saved to disk."), StatusLevel::INFO);
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -434,7 +434,7 @@ void SendCoinsDialog::on_sendButton_clicked()
             if (filename.isEmpty()) {
                 return;
             }
-            std::ofstream out(filename.toLocal8Bit().data());
+            std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out | std::ofstream::binary);
             out << ssTx.str();
             out.close();
             Q_EMIT message(tr("PSBT saved"), "PSBT saved to disk", CClientUIInterface::MSG_INFORMATION);

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ void PSBTOperationsDialog::saveTransaction() {`
`145`	`145`	`if (filename.isEmpty()) {`
`146`	`146`	`return;`
`147`	`147`	`}`
`148`		`- std::ofstream out(filename.toLocal8Bit().data());`
	`148`	`+ std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out \| std::ofstream::binary);`
`149`	`149`	`out << ssTx.str();`
`150`	`150`	`out.close();`
`151`	`151`	`showStatus(tr("PSBT saved to disk."), StatusLevel::INFO);`
Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ void SendCoinsDialog::on_sendButton_clicked()`
`434`	`434`	`if (filename.isEmpty()) {`
`435`	`435`	`return;`
`436`	`436`	`}`
`437`		`- std::ofstream out(filename.toLocal8Bit().data());`
	`437`	`+ std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out \| std::ofstream::binary);`
`438`	`438`	`out << ssTx.str();`
`439`	`439`	`out.close();`
`440`	`440`	`Q_EMIT message(tr("PSBT saved"), "PSBT saved to disk", CClientUIInterface::MSG_INFORMATION);`