Add hashPrefix option#98
Merged
madyankin merged 2 commits intomadyankin:masterfrom Sep 18, 2019
jessethomson:master
Merged
Conversation
Contributor
Author
|
I'm not sure why, but two tests unrelated to this change fail in Node 6 and 7 because autoprefixer is adding an unexpected webkit value
|
Owner
|
@jessethomson Thanks a lot for the contribution, I really appreciate it! I'll take a look at this a bit later (in one or two days) |
Contributor
Author
|
Awesome, thanks for helping me make this small contribution! |
Owner
|
I will release the new version by the end of the week |
Contributor
Author
|
Great, I look forward to it! Thanks for all you do! |
Contributor
Author
|
Can we get a new version released with this change? No rush. I know people have lives outside of open source projects so whenever you get some free time would be great 😄 |
Owner
|
Oh, crap! I have completely forgot about this. Thank you for reminding me.
I’m away from my laptop today, will release in a couple of days.
… On 4 Jan 2020, at 04:57, Jesse Thomson ***@***.***> wrote:
Can we get a new version released with this change? No rush. I know people have lives outside of open source projects so whenever you get some free time would be great 😄
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Owner
|
@jessethomson published. Sorry for keeping you waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The webpack
css-loaderhas support for ahashPrefixoption to "allow to add custom hash to generate more unique classes".In
postcss-modules, we use thegeneric-namespackage, which already supportshashPrefix.Change
This change simply adds a new
hashPrefixoption topostcss-modules, which is forwarded to thegeneric-namesgenerator.This change is backwards compatible feature and should go out in a minor release.