Add ability to transmit outputFileName into getJSON#72
Merged
madyankin merged 3 commits intomadyankin:masterfrom Oct 23, 2017
Merged
Add ability to transmit outputFileName into getJSON#72madyankin merged 3 commits intomadyankin:masterfrom
madyankin merged 3 commits intomadyankin:masterfrom
Conversation
Owner
|
@lutien Great suggestion! Could you please update the readme, too? |
Contributor
Author
|
I have added it now in an example of getJSON usage. Will it be enough? |
Owner
|
It would be great to add some tests for this. Could you add them please? |
Contributor
Author
|
I have added one test. I can not find some other cases which would be nice to cover. If you know point me, please 😊 |
Owner
|
@lutien LGTM, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
postcss-clinow there is an ability to keep folder structure that's why placement of built files can be a bit unpredictable. But still, it would be nice for some cases to keep json files with built files together. So, here is my proposal to provide output file name intogetJSONmethod to give ability use it in generation paths for json files