Use localByDefault plugin for both local and global behaviours.#130
Merged
madyankin merged 2 commits intomadyankin:masterfrom Feb 23, 2022
Merged
Use localByDefault plugin for both local and global behaviours.#130madyankin merged 2 commits intomadyankin:masterfrom
localByDefault plugin for both local and global behaviours.#130madyankin merged 2 commits intomadyankin:masterfrom
Conversation
Contributor
Author
|
@madyankin I've added tests for the change now. |
Owner
|
@fxb thank you Felix! Published. Sorry for keeping you waiting so long |
Contributor
Author
|
Thanks a lot! No worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
postcss-modules-local-by-defaultplugin actually has the modeslocal,globalandpure(link).If the plugin is NOT added in the
globalcase, shorthand selectors (link) will result in an error.Shorthand selectors are actually quite useful in SCSS with nesting.
SCSS
:local { .foo { color: red; } .bar { color: blue; } }CSS
The resulting error message (without using the plugin) is:
Adding the
postcss-modules-local-by-defaultplugin with the correctglobalmode will enable this syntax.I created this first commit directly on github.com. I can add some test cases to this PR later.