Skip to content

feat(#13): add custom lookup path option#126

Merged
madyankin merged 2 commits intomadyankin:masterfrom
kamilic:feature-look-up-path
Jul 21, 2021
Merged

feat(#13): add custom lookup path option#126
madyankin merged 2 commits intomadyankin:masterfrom
kamilic:feature-look-up-path

Conversation

@kamilic
Copy link
Copy Markdown
Contributor

@kamilic kamilic commented Jul 20, 2021

This feature is to provide an option resolve(path: string): Promise<String> | string to rewrite paths from compose/from.

@kamilic kamilic force-pushed the feature-look-up-path branch from d7e2f36 to 21717ce Compare July 20, 2021 14:54
@madyankin madyankin merged commit 8df67c9 into madyankin:master Jul 21, 2021
@madyankin
Copy link
Copy Markdown
Owner

madyankin commented Jul 21, 2021

Thanks! Published

@madyankin madyankin mentioned this pull request Jul 21, 2021
Closed
This was referenced Jul 21, 2021
Closed
Merged
Closed
Merged
Merged
@kamilic
Copy link
Copy Markdown
Contributor Author

kamilic commented Jul 22, 2021

@madyankin oh sorry, I think it need some fixes.
In resolve(path: string): Promise<String> | string, argument path is a quoted string.
It's not convenience for user to use.
I will open a another merge requests to fix it.

@kamilic kamilic mentioned this pull request Jul 22, 2021
Merged
@renovate renovate bot mentioned this pull request Jul 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamilic @madyankin @kamilic-work