Allow types that are not Encode to be used as ivars#288
Closed
Allow types that are not Encode to be used as ivars#288
Encode to be used as ivars#288Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Would be quite useful for
winit, since we don't actually need the ivars to be accessible outside Rust, and we could then avoid some unnecessary boxing.For this to work properly we'd need some parameter that states whether the instance has been initialized or not yet (since it must be safe to
deallocan instance that has not hadinitcalled on it yet).Other options maybe?
Defaultand overrideallocto always initialize each object?Copy(or ideally!Drop), and just forget the value (would allow native enums to work)ManuallyDrop, similar to abovebytemuck::ZeroableFixes #414