Skip to content

ocaml-dune: update to 3.7.0#14919

Merged
harens merged 1 commit intomacports:masterfrom
barracuda156:ocaml-dune
Mar 13, 2023
Merged

ocaml-dune: update to 3.7.0#14919
harens merged 1 commit intomacports:masterfrom
barracuda156:ocaml-dune

Conversation

@barracuda156
Copy link
Copy Markdown
Contributor

@barracuda156 barracuda156 commented May 22, 2022 •
edited
Loading

Description

Long due update. Now everything installs correctly without earlier trickery.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6 PPC
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link
Copy Markdown

macportsbot commented May 22, 2022

Notifying maintainers:
@landonf for port ocaml-dune.

@mascguy mascguy marked this pull request as draft July 13, 2022 21:18
@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Jul 15, 2022 •
edited
Loading

@pmetzger @landonf Could you suggest what fails here on bots? (Locally it built fine for me.)

File "otherlibs/configurator/src/dune", line 7, characters 17-22:
[951](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:957)
  7 |  (libraries unix csexp)
[952](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:958)
                       ^^^^^
[953](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:959)
  Error: Library "csexp" not found.
[954](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:960)
  -> required by library "dune-configurator" in
[955](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:961)
     _build/default/otherlibs/configurator/src
[956](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:962)
  -> required by _build/default/META.dune-configurator
[957](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:963)
  -> required by _build/install/default/lib/dune-configurator/META
[958](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:964)
  -> required by _build/default/dune-configurator.install
[959](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:965)
  -> required by alias install
[960](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:966)
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.2.0" && /opt/local/bin/dune build -j 3 --root=/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.2.0 --profile=release --ignore-promoted-rules --no-config --only-packages=dune-configurator --default-target=@install @install 
[961](https://github.com/macports/macports-ports/runs/6541475158?check_suite_focus=true#step:8:967)
  Exit code: 1

@barracuda156 barracuda156 changed the title ocaml-dune: update to 3.2.0 ocaml-dune: update to 3.4.1 Sep 19, 2022
@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Sep 19, 2022

For some reason configurator subport fails – it cannot find installed dependency:

--->  Configuring ocaml-dune-configurator
--->  Building ocaml-dune-configurator
Executing:  cd "/opt/local/var/macports/build/_opt_PPCRosettaPorts_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.4.1" && /opt/local/bin/dune build -j 6 --root=/opt/local/var/macports/build/_opt_PPCRosettaPorts_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.4.1 --profile=release --ignore-promoted-rules --no-config --only-packages=dune-configurator --default-target=@install @install 
File "otherlibs/configurator/src/dune", line 7, characters 17-22:
7 |  (libraries unix csexp)
                     ^^^^^
Error: Library "csexp" not found.
-> required by library "dune-configurator" in
   _build/default/otherlibs/configurator/src
-> required by _build/default/META.dune-configurator
-> required by _build/install/default/lib/dune-configurator/META
-> required by _build/default/dune-configurator.install
-> required by alias install
Command failed:  cd "/opt/local/var/macports/build/_opt_PPCRosettaPorts_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.4.1" && /opt/local/bin/dune build -j 6 --root=/opt/local/var/macports/build/_opt_PPCRosettaPorts_ocaml_ocaml-dune/ocaml-dune-configurator/work/dune-3.4.1 --profile=release --ignore-promoted-rules --no-config --only-packages=dune-configurator --default-target=@install @install 
Exit code: 1

@barracuda156 barracuda156 mentioned this pull request Sep 20, 2022
Closed
@barracuda156 barracuda156 changed the title ocaml-dune: update to 3.4.1 ocaml-dune: update to 3.6.0, fix a broken configurator build Nov 21, 2022
@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Nov 21, 2022

Hmm, the subport builds locally, just verified that. I will try to figure out why it still fails on bots. This must be fixed.

@pmetzger
Copy link
Copy Markdown
Member

pmetzger commented Nov 22, 2022

Are you attempting to build this on a system with opam? It looks like you're adding an opam file to the build as well? That might explain why it builds on your machine but doesn't build for macports.

@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Nov 22, 2022 •
edited
Loading

Are you attempting to build this on a system with opam? It looks like you're adding an opam file to the build as well? That might explain why it builds on your machine but doesn't build for macports.

@pmetzger Indeed, I have installed opam, though I did not use it directly (some OCaml ports want it, those using topkg build type).
How to fix this configurator after all? It is required, and existing Macports recipe stopped working with Dune 3.x.

Upstream discussion: ocaml/dune#6156

@barracuda156 barracuda156 changed the title ocaml-dune: update to 3.6.0, fix a broken configurator build ocaml-dune: update to 3.7.0 Mar 8, 2023
@barracuda156 barracuda156 marked this pull request as ready for review March 8, 2023 01:53
@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Mar 8, 2023

@pmetzger @reneeotten @harens This is neatly fixed now.

harens
harens approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barracuda156!

@harens harens merged commit 9020011 into macports:master Mar 13, 2023
@barracuda156 barracuda156 deleted the ocaml-dune branch March 13, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harens harens harens approved these changes

Assignees

@landonf landonf

Labels

maintainer: open Affects an openmaintainer port type: enhancement type: update

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@barracuda156 @macportsbot @pmetzger @harens @landonf