feat(pe): add parse_imports option to ParseOptions#522
Open
supervacuus wants to merge 1 commit intom4b:masterfrom
Open
feat(pe): add parse_imports option to ParseOptions#522supervacuus wants to merge 1 commit intom4b:masterfrom
parse_imports option to ParseOptions#522supervacuus wants to merge 1 commit intom4b:masterfrom
Conversation
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing
PEimport tables is expensive: for each DLL, the parser does a full pass over the import lookup table (resolving every symbolRVAvia a linear scan over sections), a second pass over the import address table, and then a third reshaping pass inImport::parse. For binaries with large or malformed import tables, this adds up fast, especially when the caller only needs headers, debug info, or exports.This PR adds a
parse_importsflag toParseOptions(default:true) with awith_parse_importsbuilder method, allowing callers to skip import table parsing entirely. When set tofalse,import_data,imports, andlibrariesremain empty while everything else is parsed as usual.This is a follow-up to #506 (#508).