Skip to content

Fix possible infinite loop guessing initial coordinates#99

Merged
lmiq merged 1 commit intom3g:masterfrom
Eigenstate:initial-coordinates
Jul 12, 2025
Merged

Fix possible infinite loop guessing initial coordinates#99
lmiq merged 1 commit intom3g:masterfrom
Eigenstate:initial-coordinates

Conversation

@Eigenstate
Copy link
Contributor

With packmol > 21.0.0 I noticed hangs guessing the initial coordinates for some systems.
The maximum number of tries variable isn't being used due to a misplaced parentheses.

Testing

  • My system that hung infinitely now builds correctly.
  • Tests in testing/ pass.
  • Used a git bisect to identify commit 589e4ca as the problem.

@lmiq lmiq merged commit b77caa9 into m3g:master Jul 12, 2025
4 checks passed
@lmiq
Copy link
Member

lmiq commented Jul 12, 2025

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants