Generate config example#128
Merged
Merged
Conversation
thomas-zahner
commented
Nov 18, 2025
|
|
||
| for (const { placeholder, value } of replacements) { | ||
| const before = content; | ||
| content = content.replace(placeholder, () => value); |
Member
Author
There was a problem hiding this comment.
Something quite interesting I learned is that replace on String knows special values for the replacement value like $'. This caused problems for the config file as replacement value. By using a function instead this weird behaviour is disabled. Average JavaScript developer experience I guess 🤷
e8e5f17 to
16acadd
Compare
mre
reviewed
Nov 18, 2025
mre
reviewed
Nov 18, 2025
mre
reviewed
Nov 18, 2025
mre
reviewed
Nov 18, 2025
katrinafyi
reviewed
Nov 18, 2025
katrinafyi
left a comment
Member
There was a problem hiding this comment.
I'm very happy to see the fetching code generalised and reused! Alongside the unit test in the main repo, this is a great improvement for documentation.
mre
reviewed
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @katrinafyi we now have a way of generating content in the docs from files of the main lychee repository. This is a follow-up PR making the base functionality applicable to other use-cases. Additionally closes lycheeverse/lychee#1768