bump default to 0.24.1 and auto-detect lychee bin in subfolder#330
Conversation
mre
left a comment
There was a problem hiding this comment.
Looks good. I will merge this right away in an attempt to reduce the blast radius of my recent changes. The comment can be added later if that seems helpful. Thanks for the fix.
| tar -xvzf "${FILENAME}" | ||
| rm -rv "${FILENAME}" | ||
|
|
||
| # Detect if lychee binary is in a subfolder within the tar.gz |
There was a problem hiding this comment.
Shall we add a comment referencing the issue and/or the release which changed the behavior?
|
Thinking about it, maybe the action should just use cargo-binstall...? Would mean there's only one place that defines the archive format. |
|
Not sure. Wouldn't that mean we have to install cargo-binstall at runtime? Or is it already installed? |
|
It would, but it's also fast - just a curl pipe. It's what the pre commit does: https://github.com/lycheeverse/lychee/blob/6eb99e8d5e49f8c93d8d71d9ddd8ebebfd4e361a/scripts/lychee_pre_commit.sh#L57 |
|
Ah right. Then sure. |
|
Hi — any rough ETA for a tagged release that includes this fix? Thanks! |
i can revert the default version bump if we'd prefer to do that later.
lycheeverse/lychee#2160