Skip to content

Publish releases on crates.io#65

Merged
mre merged 3 commits into
masterfrom
cargo-publish
Dec 4, 2020
Merged

Publish releases on crates.io#65
mre merged 3 commits into
masterfrom
cargo-publish

Conversation

@mre

@mre mre commented Dec 4, 2020

Copy link
Copy Markdown
Member

@pawroman

pawroman commented Dec 4, 2020

Copy link
Copy Markdown
Member

Have you thought about syncing git tag with Cargo crate version in Cargo.toml?

My worry is that the tags and version in Cargo.toml can get out of sync. At the very least, we should check if they are in sync before publishing.

@mre

mre commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Have you thought about syncing git tag with Cargo crate version in Cargo.toml?

Nope, but it's a great idea. Not sure how to do this, though. Are there any other projects that do that already that we can learn from?

@pawroman

pawroman commented Dec 4, 2020

Copy link
Copy Markdown
Member

Not sure how to do this, though. Are there any other projects that do that already that we can learn from?

I can do some research into it. Not a blocker for this PR though.

@mre

mre commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Thanks, then I'll merge it.
I think I'll add support for binary releases to Github, too and then cut a new 0.4.0 release.

@mre mre merged commit 3401999 into master Dec 4, 2020
@mre mre deleted the cargo-publish branch December 4, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants