Merged
Conversation
- Major changes in `lychee-lib::filter` module:
- Fields in `Excludes` except the `RegexSet` is now moved to `Filter`.
- `Filter` contains `Option<Excludes>` and `Option<Includes>`, which are
wrapper struct of `RegexSet` instead of `Option<RegexSet>`. As a result
the code now looks cleaner.
- Factored out some filtering logics to dedicated functions.
- It's possible to write tests for those functions in addition to tests
for the `Filter` struct.
- Added docs to `Filter::is_excluded` and reorgnized the code.
- placed `derive_builder` by `typed_builder`:
- The internal interface very ugly, as admitted by the author, but we no
longer have nested `Option`s like before.
- As a result, the `Client` building is much easier to read.
- Main benefit of `typed_builder` is, the arguments feeded to builder is
checked at compile time instead of run-time.
- Fixed a bug in `lychee::tests::usage` and `lychee-lib::stats::test`.
- Now it will clear environment variable which would otherwise cause an
issue if `GITHUB_TOKEN` is set.
- Updated dependencies.
Member
Author
|
Well #222 was closed since I've renamed the branch to work with git-flow. |
Closed
Member
|
lgtm. There is one final error in https://github.com/lycheeverse/lychee/pull/225/checks?check_run_id=2354928844 that should be an easy fix. |
Member
Author
|
You can build it locally, since Again we need to publish the P.S. And I haven't changed the version number. It could be v0.7.0.alpha since the API changes. |
Member
|
Works locally. Let's merge it. 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lychee-lib::filtermodule:Excludesexcept theRegexSetis now moved toFilter.FiltercontainsOption<Excludes>andOption<Includes>, which arewrapper struct of
RegexSetinstead ofOption<RegexSet>. As a resultthe code now looks cleaner.
for the
Filterstruct.Filter::is_excludedand reorgnized the code.derive_builderbytyped_builder:longer have nested
Options like before.Clientbuilding is much easier to read.typed_builderis, the arguments feeded to builder ischecked at compile time instead of run-time.
lychee::tests::usageandlychee-lib::stats::test.issue if
GITHUB_TOKENis set.