fix: align docker image version to Cargo.toml#2228
Merged
Conversation
Member
|
Thanks for the fix and an automatic update would be great. I envision some kind of workflow, which bumps the version automatically. |
Contributor
Author
|
So you create the tag, and the workflow rolls that out to the corresponding places in the codebase? I think https://github.com/marketplace/actions/write-tag-to-version-file might work for that. Just setting expectations: I personally won't have time to implement this any time soon :/ |
Member
|
I played around with it a bit. It's harder than I thought. Could only come up with super ugly, big solutions so far. Still investigating. |
Member
|
Think I found another angle in #2231. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent that these go out of sync in future, we could use something like this pre-commit hook. If you want me to, I'll propose that change in this repo.