fix: hide "cannot send response to queue: SendError" message#2209
Merged
Conversation
Fixes https://www.github.com/lycheeverse/lychee/issues/2189 The SendError message was just a distracting panic that was printed alongside a genuine error in another input URL. It should be okay to just silence the warning because if sending has failed, then the channel has dropped which means we are heading towards a main thread exit which would print any necessary messages.
c129784 to
4e31afb
Compare
thomas-zahner
approved these changes
May 28, 2026
thomas-zahner
left a comment
Member
There was a problem hiding this comment.
Thanks! That makes sense. I ran cargo fmt on your commit to fix the formatting.
This was referenced May 28, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2189
The SendError message was just a distracting panic that was printed alongside a genuine error in another input URL.
It should be okay to just silence the warning. If sending has failed, then the channel has dropped which means we are heading towards a main thread exit which would print any necessary messages.