Use hints for root-relative links error#2197
Merged
Merged
Conversation
Co-authored-by: Thomas Zahner <thomas.zahner@protonmail.ch>
Member
|
@katrinafyi Thank you for the PR and the extensive discussion on #2195! 🚀 |
This was referenced May 29, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2195 by moving the suggestion into a user hint and adding a sentence about possible impacts on relocatable sites.
New error looks like:
Happy to tweak any part of the phrasing.
I've kept it as "locally-relative" (rather than @ roberth's suggestion of page-/document-relative), because I think it's more straightforward when it refers to files on disk. Page and document both need the user to think about web pages before connecting it a file path. MDN calls them current directory relative. That's a bit long but I also wouldn't mind "directory-relative".