chore: strip the release debug info#2184
Merged
Merged
Conversation
As we discussed in lycheeverse#1931 (comment) Signed-off-by: Keming <kemingy94@gmail.com>
Member
|
Guess this makes sense as this simply uses Cargo's default behaviour. @mre What was the reason for enabling the debug profile in release mode? Do we get additional debug information in the stack trace when lychee panics? |
Member
|
Yeah, I wondered about that, too. Apparently, I introduced it when I refactored the extractor from a pure function into its own struct. Not sure why I enabled the debug symbols in general. Probably because I benchmarked during that refactor to make sure there were no regressions. I believe they need to be enabled so that cargo-flamegraph can show the function names in the chart. But not 100% sure. Either way, it's wasteful to enable that for release builds without a good reason. |
Member
|
Ah that makes sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discussed in #1931 (comment)