ci: move binstall-check to on release and use /nightly/ URL#2182
Merged
Conversation
running in the release-binary workflow and after the build-release step means that the release binaries will always be available when the binstall check runs. for nightly releases, we also change the URL to `/nightly/` which lets us preview upcoming archive structure changes in the next version. moving the check into release-binary might make a failing check less visible, but maybe that's okay.
Member
|
Thanks! Let's try it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running in the release-binary workflow and after the build-release step means that the release binaries will always be available when the binstall check runs.
for nightly releases, we also change the URL to
/nightly/which lets us preview upcoming archive structure changes in the next version.should fix #2170 (comment), but i can't test it.
moving the check into release-binary might make a failing check less visible, but maybe that's okay. we should keep an eye on https://github.com/lycheeverse/lychee/actions?query=event%3Aschedule+event%3Arelease or add the badges somewhere visible, maybe in the release PR text.