Skip to content

ci: fix links.yml by adding --root-dir argument#2168

Merged
thomas-zahner merged 1 commit into
lycheeverse:masterfrom
rina-forks:fix-links
May 7, 2026
Merged

ci: fix links.yml by adding --root-dir argument#2168
thomas-zahner merged 1 commit into
lycheeverse:masterfrom
rina-forks:fix-links

Conversation

@katrinafyi

Copy link
Copy Markdown
Member

the daily link check of this repo has been failing for some time:

[ERROR] error: | Error building URL for "/CONTRIBUTING.md" (Attribute:
Some("href")): Cannot convert path '/CONTRIBUTING.md' to a URI: To
resolve root-relative links in local files, provide a root dir

https://github.com/lycheeverse/lychee/actions/workflows/links.yml

i didn't look into why the create issue step isn't working. maybe env.lychee_exit_code is referencing the wrong thing?

the daily link check of this repo has been failing for some time:

    [ERROR] error: | Error building URL for "/CONTRIBUTING.md" (Attribute:
    Some("href")): Cannot convert path '/CONTRIBUTING.md' to a URI: To
    resolve root-relative links in local files, provide a root dir

https://github.com/lycheeverse/lychee/actions/workflows/links.yml

i didn't look into why the create issue step isn't working. maybe
`env.lychee_exit_code` is referencing the wrong thing?

@mre mre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomas-zahner thomas-zahner merged commit 040abc8 into lycheeverse:master May 7, 2026
8 checks passed
@katrinafyi

Copy link
Copy Markdown
Member Author

Link check looks good now. There's just a few false positives https://github.com/lycheeverse/lychee/actions/runs/25609256263/attempts/1#summary-75176463855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants