check HTTP status in archive snapshots and ignore 503 in test#2158
Merged
Conversation
this should fix the flakiness while still detecting an error if the API ever changes and it starts 404ing or something.
thomas-zahner
approved these changes
Apr 24, 2026
thomas-zahner
left a comment
Member
There was a problem hiding this comment.
Ah thank you!
It really is unfortunate how unstable their API is. At some days it feels like there's a 50% chance the requests fail, while other days the API seems quite stable.
Merged
Member
|
Ah, this is such a great way to fix it. I learned something. Thanks for fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix the flakiness while still detecting an error if the API ever changes and it starts 404ing or something.