refactor: make website checker return Status always, rather than Result#2140
Merged
Merged
Conversation
this means that the Err case of `Client::check` will only happen due to remap failures. this means the error cases we have to handle are much clearer. this commit re-lands this refactor which was previously part of lycheeverse#2124. there's a bit more context in that PR.
53d3ba8 to
5a0f615
Compare
Member
|
Resolved the conflicts with ef5652c due to the updated signatures and test additions. |
Member
|
Thank you for this nice and simple PR! I don't see any problems. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this means that the Err case of
Client::checkwill only happen due to remap failures. this means the error cases we have to handle are much clearer.this commit re-lands this refactor which was previously part of #2124. there's a bit more context in that PR.