Move caching logic to cache#2123
Merged
Merged
Conversation
Member
|
edit: nvm check is a provided function, it's happy days. |
katrinafyi
reviewed
Apr 2, 2026
katrinafyi
left a comment
Member
There was a problem hiding this comment.
i think it's good to centralise this logic, especially the logic around which requests/responses are bypassing the cache.
katrinafyi
reviewed
Apr 2, 2026
katrinafyi
approved these changes
Apr 6, 2026
katrinafyi
left a comment
Member
There was a problem hiding this comment.
I would be fine with merging this. (and it would deconflict some other PRs 🙂
Make `Cache` a struct instead of a type alias and move logic associated to caching into appropriate functions to improve readability and clarify responsibilities.
5daaaa2 to
f066a9b
Compare
Merged
mre
reviewed
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Cachea struct instead of a type alias and move logic associated to caching into appropriate functions to improve readability and clarify responsibilities.This is a follow up to #2109