@katrinafyi Thank you very much for the fix! The merge commit should which includes additional changes and causes the merge conflict should not be necessary. See https://github.com/thomas-zahner/lychee/commits/rustls-fix/ for a rebased version. (I again wasn't allowed to push to this branch)

I'd sent you an invite to the repo. It should be in your email, or maybe there's a button at https://github.com/rina-forks/lychee.
I found that there was no checkbox I could tick on the PR page

I'd sent you an invite to the repo.

Ah thank you! I now got one step further. But due to branch rules/protections I'm unable to force push. Could you allow force pushes to all branches (or non-master) buy modifying the rule set or by deleting it?

remote: error: GH013: Repository rule violations found for refs/heads/rustls-fix.
remote: Review all repository rules at https://github.com/rina-forks/lychee/rules?ref=refs%2Fheads%2Frustls-fix
remote:
remote: - Cannot force-push to this branch
remote:
To github.com:rina-forks/lychee.git
 ! [remote rejected]   rustls-fix -> rustls-fix (push declined due to repository rule violations)
error: failed to push some refs to 'github.com:rina-forks/lychee.git'

Done~

@katrinafyi Thank you. I think in that case it makes more sense to specifically test the function causing the panic instead of using such abstract cli tests. Do you agree with d3f3c60?

Yeah I don't really mind either way. It is nice to be more specific.

Thanks. I feel that being more specific with testing should be done when possible. In lychee we tend to have many CLI integration tests (which is great) but it might make sense to also have more "low-level" tests.

It's true. I definitely use CLI tests more often just because they're easier to write 😅

Haha yes I also tend to do this, which might not always be ideal 😄