Skip to content

Add snap config and GitHub Action#1786

Merged
mre merged 4 commits into
lycheeverse:masterfrom
steinbro:snap
Aug 10, 2025
Merged

Add snap config and GitHub Action#1786
mre merged 4 commits into
lycheeverse:masterfrom
steinbro:snap

Conversation

@steinbro

@steinbro steinbro commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Adds a package format requested but not yet fulfilled from #59. Also adds a workflow to automatically build and publish to the snap store. The latter requires credentials to be configured in CI variables to publish from the appropriate account.

@mre

mre commented Aug 8, 2025

Copy link
Copy Markdown
Member

Thanks for that awesome PR @steinbro!

Added the credentials. It's still failing because it can't find them. Not sure what's up. Do I need to merge before it can find the secrets? Probably not. It might be because it's on your fork. I checked the instructions over on snapcore/action-publish and I can't see any missing steps. 🤔

In general, we should only run this workflow on new releases. We should add that condition to the pipeline (at least as a comment for now). Can you do that? You can check the other workflows for reference.

@steinbro

steinbro commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

Snaps have a concept of "channels" for distributing e.g. nightly vs. stable builds. I've tweaked the workflow to publish to the edge channel for all commits to master, and to stable for all commits with a version tag. It should now also automatically assign a version number from the git tag as well.

I'm not sure what's going on with the build secrets, but I've also now set the job to not run at all on pull requests.

@mre mre merged commit 6e61e35 into lycheeverse:master Aug 10, 2025
6 checks passed
@mre

mre commented Aug 10, 2025

Copy link
Copy Markdown
Member

Very nice. The PR looks good to me, so I merged it. If it doesn't work, we can always tweak it later. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants