Skip to content

feat: Relative Url#15

Merged
mre merged 5 commits intolycheeverse:masterfrom
whizsid:relative_urls
Oct 20, 2020
Merged

feat: Relative Url#15
mre merged 5 commits intolycheeverse:masterfrom
whizsid:relative_urls

Conversation

@whizsid
Copy link
Contributor

@whizsid whizsid commented Oct 19, 2020

Sorry for the delay. 😄 😆 Fixes #3

@whizsid
Copy link
Contributor Author

whizsid commented Oct 19, 2020

https://github.com/hello-rust/lychee/pull/15/files#diff-9bfca03419915f4d4c69bb43d30e158a84c63d0f68c35c4991fd659d8b158f1cR10-R12

pulldown-cmark library is splitting http://[::1] into four parts (http://,[,::1,]) when the URL is not in a URL section.

@mre
Copy link
Member

mre commented Oct 19, 2020

Looks great!
Only thing I'd add is a unit test for extract_links with a some base_url (on top of the integration test you already added). Other than that it's ready to merge from my perspective. Code is very readable.

@mre
Copy link
Member

mre commented Oct 20, 2020

Thanks for adding the unit tests and for your contribution in general @whizsid. LGTM. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support relative URLs

2 participants