Skip to content

feat: Expand serde deserialize impl#1345

Merged
mre merged 2 commits into
lycheeverse:masterfrom
Techassi:feat/expand-serde-impl
Jan 9, 2024
Merged

feat: Expand serde deserialize impl#1345
mre merged 2 commits into
lycheeverse:masterfrom
Techassi:feat/expand-serde-impl

Conversation

@Techassi

@Techassi Techassi commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

Fixes #1338

The config now supports a list of integers and a single integer as the accept value.

@Techassi

Techassi commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

Seems like the lychee::cli::test_suggests_url_alternatives test is flaky again.

@mre

mre commented Jan 9, 2024

Copy link
Copy Markdown
Member

Awesome PR. Lifesaver!

Yup, sorry about that. That happens when archive.org takes too long to send a response. We have exponential back off in place, but it might be better to disable the test altogether. 😕
I re-ran it and now the error seems to be relevant to the changes. Can you take a look?

@Techassi

Techassi commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

I re-ran it and now the error seems to be relevant to the changes. Can you take a look?

Yes, will do.

@Techassi

Techassi commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

The test ran fine multiple times on my local machine. The description states that it is flaky:

Unfortunately, LinkedIn does not always return 999, so this is a flaky test. We only check that the cache file doesn't contain any invalid status codes.

@mre

mre commented Jan 9, 2024

Copy link
Copy Markdown
Member

LinkedIn never fails to deliver. 😆 Merging. Thanks for the quick fix!🥇

@mre mre merged commit 1ab05ef into lycheeverse:master Jan 9, 2024
@Techassi

Techassi commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

LinkedIn never fails to deliver.

Lol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load configuration file: invalid type: integer 200, expected a string

2 participants