Skip to content

Fix URI cache to cache URIs across multiple files #348

@MichaIng

Description

@MichaIng

As tested here, the URI cache for caching URI check results across all input files, does not work as expected.

There is a test for repetition in a single file: https://github.com/lycheeverse/lychee/blob/master/lychee-bin/tests/cli.rs#L218-L229
But this worked before the new URI cache was implemented. This test may be extended to use two identical files.
@mre
Is it actually intended that two identical URLs in two separate files contribute only 1 to the total of the summary, or is it still 1 per input (and only the actual request skipped internally)? In the latter case, expanding or implementing the test would be more difficult.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions