why these two produce different outputs?

➜  lychee git:(master) ✗ cargo run https://github.com/lycheeverse/lychee/issues/1736
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s
     Running `target/debug/lychee 'https://github.com/lycheeverse/lychee/issues/1736'`
  103/103 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                              Issues found in 1 input. Find details below.

[https://github.com/lycheeverse/lychee/issues/1736]:
     [406] https://github.com/lycheeverse/lychee/sponsor_button | Rejected status code (this depends on your "accept" configuration): Not Acceptable
     [404] https://github.com/search/custom_scopes/check_name | Rejected status code (this depends on your "accept" configuration): Not Found
     [404] https://github.com/search/feedback | Rejected status code (this depends on your "accept" configuration): Not Found
     [404] https://github.githubassets.com/ | Rejected status code (this depends on your "accept" configuration): Not Found

🔍 103 Total (in 4s) ✅ 99 OK 🚫 4 Errors
   [WARN ] There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.


➜  lychee git:(master) ✗ cargo run -
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.45s
     Running `target/debug/lychee -`
https://github.com/lycheeverse/lychee/issues/1736
🔍 1 Total (in 8s) ✅ 1 OK 🚫 0 Errors

as for the progress bar, I think we could overwrite no_progress when loading the config, if the input is Stdin

if let Ok(inputs) = opts.inputs() {
        if inputs
            .iter()
            .any(|input| input.source == InputSource::Stdin)
        {
            opts.config.no_progress = true;
        }
    }

Uh oh!

Don't update progress bar when waiting for user input #1736

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions