Thanks. Any recent libiconv version will probably do, but IIUC you reverted libxml2 to winlibs/libxml2@cece36e, right? That's too old. I'd like to stick with winlibs/libxml2@6a6690c. What were the missing symbols? Do you have a build log for that?

@scoder I looked into it a bit more and it seems like the problem is due to libxml2 header files by default trying to link against DLL by adding the import library prefixes which causes the many link error I saw previously.

etree.obj : error LNK2001: unresolved external symbol __imp_xmlC14NDocSave
etree.obj : error LNK2001: unresolved external symbol __imp_xmlSchematronValidateDoc
etree.obj : error LNK2001: unresolved external symbol __imp_xmlSchematronNewParserCtxt
etree.obj : error LNK2001: unresolved external symbol __imp_xmlSchematronNewDocParserCtxt

I think the fix would be to add a compile flag while building lxml extension modules to link against the static library. Something like following would work

--- a/setupinfo.py
+++ b/setupinfo.py
@@ -122,7 +122,7 @@ def ext_modules(static_include_dirs, static_library_dirs,
     _library_dirs = _prefer_reldirs(base_dir, library_dirs(static_library_dirs))
     _cflags = cflags(static_cflags)
     _ldflags = ['-isysroot', get_xcode_isysroot()] if sys.platform == 'darwin' else None
-    _define_macros = define_macros()
+    _define_macros = [('LIBXML_STATIC', 1)]
     _libraries = libraries()

     if _library_dirs:

I have reverted the submodule update for libxml2 and libxslt to use the latest as before. So this can be merged if you are okay.

And I can open a PR for lxml to add this extra change build against the static library

@scoder Just pinging in case you missed previous update

Not sure why you want a macro for this. Isn't it just something to add to the extra_objects of the Extension setup further down? That's what the static_binaries argument is there for.

Not sure why you want a macro for this. Isn't it just something to add to the extra_objects of the Extension setup further down? That's what the static_binaries argument is there for.

There may be a better way to add this flag. I am not sure. But for compiling against static library we will need to define LIBXML_STATIC during the c/c++ compilation.

If you are happy we could merge this patch and could look into options of defining the macro while building lxml ?

I pushed lxml/lxml@7837d13. Does that solve the issue?

I pushed lxml/lxml@7837d13. Does that solve the issue?

Yes I think that should work. Thanks

Thanks a lot. Let's see what appveyor makes of this.

Thanks, @scoder. Could you make a release with the appveyor artifacts please?

Thanks @scoder. I've tried with top of lxml and everything seems to be working fine