Skip to content

Commit 3482654

Browse files
ci: fold parity into QA release validation
1 parent 0516218 commit 3482654

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

scripts/check-docker-e2e-boundaries.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ function validateUniqueLanes(label, lanes) {
5858
}
5959

6060
function validateLane(label, lane) {
61+
const resources = laneResources(lane);
6162
if (!lane.name || typeof lane.name !== "string") {
6263
errors.push(`${label}: Docker E2E lane is missing a string name`);
6364
}
@@ -70,7 +71,7 @@ function validateLane(label, lane) {
7071
`${label}: Docker E2E lane '${lane.name}' has invalid image kind '${lane.e2eImageKind}'`,
7172
);
7273
}
73-
if (lane.live && lane.e2eImageKind) {
74+
if (lane.live && lane.e2eImageKind && !resources.includes("npm")) {
7475
errors.push(`${label}: live Docker E2E lane '${lane.name}' must not require a package image`);
7576
}
7677
if (!lane.live && !lane.e2eImageKind) {
@@ -79,7 +80,7 @@ function validateLane(label, lane) {
7980
if (laneWeight(lane) < 1) {
8081
errors.push(`${label}: Docker E2E lane '${lane.name}' must have positive weight`);
8182
}
82-
if (!laneResources(lane).includes("docker")) {
83+
if (!resources.includes("docker")) {
8384
errors.push(`${label}: Docker E2E lane '${lane.name}' must include the docker resource`);
8485
}
8586

0 commit comments

Comments
 (0)