Support for the Incus Agent as a Service on Windows #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
requested changes
Nov 18, 2025
Member
stgraber
left a comment
There was a problem hiding this comment.
Just a few nits and code style things
f15fc12 to
3958a17
Compare
Signed-off-by: Marc Olivier Bergeron <mbergeron28@proton.me>
3958a17 to
221cdda
Compare
stgraber
approved these changes
Nov 18, 2025
Member
|
Thanks a lot, that will make it a LOT more approachable for Windows users! Could you add another commit to tweak the documentation? That should be in |
Signed-off-by: Marc Olivier Bergeron <mbergeron28@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to add better support for the Incus agent under Windows as a service with the installation scripts.
Not so Sure About Those...
I'm not sure about
m.agentCmd.mountHostShares()at line 48 inos_windows.goif it is necessary. There might be things missing but I was not sure it they were necessary such as the notification channels.How to Use
Simply add the CD-ROM to the virtual machine with
incus config device add my-windows-vm cdrom disk source=agent:configand then, run as an administrator theinstall.ps1from the CD-ROM drive within the virtual machine.