Handle USB cdrom drives #2402
Merged
Handle USB cdrom drives #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Member
Author
|
@bensmrs I don't know if that helps with any of your stuff, but it might. Took be a solid day to figure this stuff out... |
Contributor
|
Wow, great catch!
At this point, what surprises me is when QEMU isn’t weird.
Nah, my stuff is mostly sorted out, I’m just lacking some time to work on it. But hey, we never know :) |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USB mass storage with QEMU is pretty weird. There is no way to pass through the
mediaargument to have it give us a CD-ROM drive on its own, instead theusb-storagedriver only does disk devices and generates an internal SCSI device.To fix this, we need to switch to either
usb-botorusb-uas. The former still uses theusb-storagedriver and doesn't need anything special at the guest level, so that's how I went here.With this in place, we can now have anything marked as an ISO show up as a cdrom device rather than mass storage. That's particularly important for the Windows installer which with this will now function without any need for repacking of the install ISO.