add DisparityWidth, Disparity Companding, SubpixelFractionalBits options#279
Merged
Serafadam merged 3 commits intoluxonis:humblefrom Apr 20, 2023
Merged
add DisparityWidth, Disparity Companding, SubpixelFractionalBits options#279Serafadam merged 3 commits intoluxonis:humblefrom
Serafadam merged 3 commits intoluxonis:humblefrom
Conversation
Signed-off-by: Borong Yuan <yuanborong@hotmail.com>
Signed-off-by: Borong Yuan <yuanborong@hotmail.com>
Signed-off-by: Borong Yuan <yuanborong@hotmail.com>
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding these options can help with better Stereo Depth tuning.
Using DISPARITY_64 alone is not a good idea. But it's not the same when using it with other parameters. The doc says "Median filter postprocessing is supported only for 3 fractional bits". This is because the median filter supports a maximum of 1024 Disparity. For DISPARITY_96 and 4 fractional bits, the maximun disparity is 1520. However, for DISPARITY_64 and 4 fractional bits, the maximum disparity is 1008, which is just below the limit. Another choice is to use DISPARITY_64 with extended disparity and 3 fractional bits. It's maximun disparity is also 1008. Which means the disparity range is increased to 126, while median filter is still available.
Another way to increase disparity range is to enable Companding. Unlike extended disparity, it does not consume more HW resources. So it is useful for high resolution inputs.
After adding these options, I found the following two sets of good parameter combinations.