Skip to content

Filter bucket list by region #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lusingander merged 4 commits into from
Jul 8, 2024
Merged

Filter bucket list by region #13

lusingander merged 4 commits into from
Jul 8, 2024

Conversation

@henrikskog
Copy link
Contributor

@henrikskog henrikskog commented Jul 7, 2024 •
edited
Loading

Fixes #12

If you want I can get the locations in parallell. I'm a complete novice in Rust so there are probably ways of writing this neater as well!

lusingander
lusingander requested changes Jul 7, 2024
View reviewed changes
Copy link
Owner

@lusingander lusingander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I’ve left a few minor comments.

If you want I can get the locations in parallell.

I agree that reducing the number of requests corresponding to the number of buckets is an improvement we should consider. However, I don't think it needs to be addressed in this pull request.

In practice, bucket names are unique, and regions rarely change, so I think it's acceptable to cache this information.

@henrikskog
Copy link
Contributor Author

henrikskog commented Jul 7, 2024

Thank you for the review! I'll hopefully take a look at it tonight or tomorrow :)

@henrikskog henrikskog requested a review from lusingander July 7, 2024 19:04
@henrikskog
Copy link
Contributor Author

henrikskog commented Jul 7, 2024

In practice, bucket names are unique, and regions rarely change, so I think it's acceptable to cache this information.

You want me to take a shot at implementing this?

lusingander
lusingander requested changes Jul 7, 2024
View reviewed changes
@lusingander
Copy link
Owner

lusingander commented Jul 7, 2024

In practice, bucket names are unique, and regions rarely change, so I think it's acceptable to cache this information.

You want me to take a shot at implementing this?

You don't necessarily have to address this issue. But if you'd like to take it on, you are welcome to do so.

henrikskog
henrikskog commented Jul 8, 2024
View reviewed changes
@henrikskog
Copy link
Contributor Author

henrikskog commented Jul 8, 2024 •
edited
Loading

You don't necessarily have to address this issue. But if you'd like to take it on, you are welcome to do so.

Okay great, I'd like to 👍

@lusingander lusingander merged commit 279edc8 into lusingander:master Jul 8, 2024
@lusingander
Copy link
Owner

lusingander commented Jul 8, 2024

Thank you!

@henrikskog henrikskog deleted the filter-bucket-list-by-region branch July 9, 2024 20:02
@henrikskog henrikskog mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lusingander lusingander lusingander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter bucket list by region

2 participants

@henrikskog @lusingander