Use the "http.Server" type instead of "net.Server"#224
Open
theandrew168 wants to merge 1 commit intolukeed:nextfrom
Open
Use the "http.Server" type instead of "net.Server"#224theandrew168 wants to merge 1 commit intolukeed:nextfrom
theandrew168 wants to merge 1 commit intolukeed:nextfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this project! While working on a PR for SvelteKit, I noticed that
polka.serverwas typed as a net.Server instead of an http.Server. Since this project is a web server, I figured that using the latter would be more appropriate. It should be backwards compatible with all existing code becausehttp.Serverextendsnet.Server. Plus, it'll make the types more accurate for some of the tweaks made by SvelteKit's adapter-node (example, example).