Skip to content

Add array creation support#9

Merged
lukeed merged 9 commits into
lukeed:masterfrom
bwendt-mylo:master
Sep 7, 2018
Merged

Add array creation support#9
lukeed merged 9 commits into
lukeed:masterfrom
bwendt-mylo:master

Conversation

@bwendt-mylo

@bwendt-mylo bwendt-mylo commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@bwendt-mylo

Copy link
Copy Markdown
Contributor Author

@lukeed Think this is worth merging in?

@lukeed

lukeed commented Sep 5, 2018

Copy link
Copy Markdown
Owner

Hey, thanks! Sorry for the delay... can't stand that reading emails marks it as read 😞

Can we revert the build tool change? I can make UMD-compat separately – interested in the bytes increase with this feature alone.

You can also do +keys[i + 1] instead of parseInt(..., 10) in this case.

Thank you~!

@bwendt-mylo bwendt-mylo changed the title Add array creation support; Add UMD support Add array creation support Sep 6, 2018
@bwendt-mylo

Copy link
Copy Markdown
Contributor Author

Build tool change removed. Also good suggestion on the +keys[i + 1], that shaved off some bytes, getting it down to 161B.

@lukeed

lukeed commented Sep 7, 2018

Copy link
Copy Markdown
Owner

Hey, it's now 144B 😉

I think this should be the normal/default behavior, marking a 2.0 release 🎉Rarely, if ever, should { '0': 'hello', '1': 'world' } actually be preferred, but just in case the major bump will safeguard that use.

This was great, missing functionality. Thanks!

@lukeed lukeed merged commit e6fea6f into lukeed:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants