Fix incorrect lookup in non-root nodes#31
Merged
luislavena merged 1 commit intomasterfrom Jan 31, 2021
Merged
Conversation
Given the following non-root tree: tree = Tree(Symbol).new tree.add "/prefix/", :prefix tree.add "/prefix/foo", :foo Attempt to lookup for `/foo` was incorrectly identifying `:foo` entry as the correct value. This change ensures that child nodes of the current node are not scanned if key and path being looked up do not match. Fixes #27
d55c949 to
f764b3a
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following non-root tree:
Attempt to lookup for
/foowas incorrectly identifying:fooentry as the correct value.This change ensures that child nodes of the current node are not scanned if key and path being looked up do not match.
Fixes #27