remove the SSLR (slow start large reduction) experiment#2680
Merged
marten-seemann merged 1 commit intomasterfrom Jul 23, 2020
Merged
remove the SSLR (slow start large reduction) experiment#2680marten-seemann merged 1 commit intomasterfrom
marten-seemann merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2680 +/- ##
==========================================
- Coverage 86.74% 86.67% -0.07%
==========================================
Files 124 124
Lines 9897 9895 -2
==========================================
- Hits 8585 8576 -9
- Misses 978 983 +5
- Partials 334 336 +2
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jul 22, 2020
|
|
||
| // SetSlowStartLargeReduction allows enabling the SSLR experiment | ||
| func (c *cubicSender) SetSlowStartLargeReduction(enabled bool) { | ||
| c.slowStartLargeReduction = enabled |
Member
There was a problem hiding this comment.
We can probably remove the member & other references then?
Member
Author
There was a problem hiding this comment.
Oh nice, that removes another 10 LOC or so.
c0eda91 to
c744525
Compare
We apparently copied that code over from Chromium's Cubic implementation, but we certainly don't need it.
c744525 to
2db579f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We apparently copied that code over from Chromium's Cubic implementation, but we certainly don't need it.