introduce type aliases in the logging package#2643
Merged
marten-seemann merged 3 commits intomasterfrom Jul 6, 2020
Merged
Conversation
b2b006c to
fb39ccc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2643 +/- ##
==========================================
+ Coverage 86.32% 86.37% +0.05%
==========================================
Files 122 122
Lines 9754 9757 +3
==========================================
+ Hits 8420 8427 +7
+ Misses 999 995 -4
Partials 335 335
Continue to review full report at Codecov.
|
6ece5ff to
e9272f3
Compare
lucas-clemente
approved these changes
Jul 5, 2020
83282eb to
c805cdf
Compare
c805cdf to
ed120f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers all types. It also introduces type aliases for the
wire.Frames. STREAM and CRYPTO frames are redefined, so that theloggingpackage doesn't get access to the data sent.