Skip to content

return an infinite bandwidth if the RTT is zero#2636

Merged
marten-seemann merged 1 commit intomasterfrom
fix-bandwidth-estimate-for-short-rtts
Jul 1, 2020
Merged

return an infinite bandwidth if the RTT is zero#2636
marten-seemann merged 1 commit intomasterfrom
fix-bandwidth-estimate-for-short-rtts

Conversation

@marten-seemann
Copy link
Copy Markdown
Member

Fixes #2630. Fixes #2635.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2020

Codecov Report

Merging #2636 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2636   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         123      123           
  Lines        9787     9787           
=======================================
  Hits         8445     8445           
  Misses       1000     1000           
  Partials      342      342           
Impacted Files Coverage Δ
internal/congestion/bandwidth.go 100.00% <ø> (ø)
internal/congestion/cubic_sender.go 91.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc047d7...a20c5f8. Read the comment docs.

@marten-seemann marten-seemann merged commit eb57da6 into master Jul 1, 2020
@marten-seemann marten-seemann deleted the fix-bandwidth-estimate-for-short-rtts branch July 1, 2020 06:58
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pacer returns send time in the past, although it has no send budget flaky benchmark test on AppVeyor

2 participants