Skip to content

retire conn IDs with sequence numbers smaller than the currently active#2563

Merged
marten-seemann merged 1 commit intomasterfrom
fix-reordered-ncid-frame
May 25, 2020
Merged

retire conn IDs with sequence numbers smaller than the currently active#2563
marten-seemann merged 1 commit intomasterfrom
fix-reordered-ncid-frame

Conversation

@marten-seemann
Copy link
Copy Markdown
Member

Fixes #2547.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2020

Codecov Report

Merging #2563 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
- Coverage   86.17%   86.15%   -0.02%     
==========================================
  Files         122      122              
  Lines        9550     9550              
==========================================
- Hits         8229     8227       -2     
- Misses        983      984       +1     
- Partials      338      339       +1     
Impacted Files Coverage Δ
conn_id_manager.go 92.23% <100.00%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa69438...b0c1aed. Read the comment docs.

@marten-seemann marten-seemann merged commit 4e8d244 into master May 25, 2020
@marten-seemann marten-seemann deleted the fix-reordered-ncid-frame branch May 25, 2020 12:04
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reordered NEW_CONNECTION_ID frame is not retired

3 participants