Skip to content

stop the timer when the session's run loop returns#2516

Merged
marten-seemann merged 2 commits intomasterfrom
stop-timer
May 2, 2020
Merged

stop the timer when the session's run loop returns#2516
marten-seemann merged 2 commits intomasterfrom
stop-timer

Conversation

@marten-seemann
Copy link
Copy Markdown
Member

Fixes #2515.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 2, 2020

Codecov Report

Merging #2516 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2516   +/-   ##
=======================================
  Coverage   86.13%   86.14%           
=======================================
  Files         122      122           
  Lines        9533     9536    +3     
=======================================
+ Hits         8211     8214    +3     
  Misses        984      984           
  Partials      338      338           
Impacted Files Coverage Δ
internal/utils/timer.go 100.00% <100.00%> (ø)
session.go 75.34% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d66eac...286dcf5. Read the comment docs.

@marten-seemann marten-seemann merged commit c0b6d4e into master May 2, 2020
@marten-seemann marten-seemann deleted the stop-timer branch May 6, 2020 01:18
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stop the timer when the session is closed

3 participants