Skip to content

Fix type(x) == "vector" always refining x to never#2291

Merged
vegorov-rbx merged 4 commits intoluau-lang:masterfrom
PhoenixWhitefire:type-vector-2
Mar 26, 2026
Merged

Fix type(x) == "vector" always refining x to never#2291
vegorov-rbx merged 4 commits intoluau-lang:masterfrom
PhoenixWhitefire:type-vector-2

Conversation

@PhoenixWhitefire
Copy link
Copy Markdown
Contributor

@PhoenixWhitefire PhoenixWhitefire commented Mar 12, 2026

Fixes

local x: unknown

if type(x) == "vector" then -- Lint warning
    local y = x -- `never`
end

Adds flags LuauRefinementTypeVector and LuauLinterVectorPrimitive. Modified 1 Linter test and 1 refinement test. Adds 1 refinement test.

@PhoenixWhitefire PhoenixWhitefire marked this pull request as ready for review March 12, 2026 14:04
vegorov-rbx
vegorov-rbx reviewed Mar 26, 2026
View reviewed changes
@vegorov-rbx
Copy link
Copy Markdown
Collaborator

vegorov-rbx commented Mar 26, 2026

Looks good, but needs a flag update.

vegorov-rbx
vegorov-rbx reviewed Mar 26, 2026
View reviewed changes
@PhoenixWhitefire
Copy link
Copy Markdown
Contributor Author

PhoenixWhitefire commented Mar 26, 2026

Oh it didn't show the approval message before I re-requested

@vegorov-rbx
Copy link
Copy Markdown
Collaborator

vegorov-rbx commented Mar 26, 2026

Thank you.

@vegorov-rbx vegorov-rbx merged commit 3634cb4 into luau-lang:master Mar 26, 2026
7 checks passed
@vegorov-rbx vegorov-rbx mentioned this pull request Mar 26, 2026
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vegorov-rbx vegorov-rbx vegorov-rbx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhoenixWhitefire @vegorov-rbx