Merged
Conversation
In tensorflow 1.11 tensorflow.default doesn't have the PLUGIN_LOADERS attribute, but the _PLUGINS one. Moreover, the program.TensorBoard class constructor can take the default arguments correctly if they're not passed, this avoids the need to make another if branch for the 1.11 version.
Without argparse would throw "unrecognized arguments:"
Owner
|
Thanks very much for your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to use the plugin with the last versions of tensorflow (1.11) and jupyter but it would give an error.
I've noticed that it wasn't recognizing the 1.11 version and it was still using the old api while creating the tensorboard app. I've fixed the problem and tested it.
Davide