Here's some issues that my editor (Eclipse PyDeV) points out in core.py (line numbers are for my samp1 branch):

Description Resource    Path    Location    Type
Undefined variable: keyfile core.py /astropy/astropy/vo/samp    line 3372   PyDev Problem
Undefined variable: _hubAsClientRequestHandler  core.py /astropy/astropy/vo/samp    line 1766   PyDev Problem
Undefined variable: certfile    core.py /astropy/astropy/vo/samp    line 3372   PyDev Problem
Duplicated signature: _notifyAll    core.py /astropy/astropy/vo/samp    line 2611   PyDev Problem

@lpaioro Are these real issues? Can you fix them?

@cdeil - it's not currently possible to see full diff as it indicates there are a lot of changes. Any ideas on how we can see them easily?

That's because I ran autopep8 and most things weren't indented with 4 spaces.

Probably best to look at each commit except that one individually.
Or look at it locally.

Ok, so maybe the solution is to look though the individual ones and just trust the autopep8 one since it's still too large (or use diff -w locally to ignore whitespace changes).

@cdeil - I tried to have a look at the diff for the autopep8 offline, and I think that you should not let it shorten lines for now, as the result is not always more readable (it's the one PEP8 thing where we are not systematic). I would recommend using:

autopep8 --ignore=E501

and then leaving line wrapping for now. This will also make the diff simpler, because then most of the changes will be whitespace, and it's possible to silence those. In fact, I'd even recommend we keep the PEP8 in a separate pull request, because it'll then be much easier to review the actual changes here. Do you think you could easily just take out the autopep8 from here and then once this is merged, you can open a new PR with autopep8 (with the ignore clause to avoid automatically wrapping lines?)

I made a new PR without the autopep8 changes:
#2

Let's try to get astropy.vo.samp working first and then do the cleanup later.